Andy_Allan

icon indicating a website link andya1lan.github.io

icon company Southern Medical University icon location Singapore icon location B.Sc in Bioinformatics, Southern Medical University

Results 4 comments of Andy_Allan

fix(ssh): SSH agent IdentitiesOnly logic and public key parsing

Hi @sawka Code Rabbit suggest that https://github.com/wavetermdev/waveterm/blob/a07e078b97687b2c6bf9580225584cd9e4d63795/pkg/remote/sshclient.go#L972 won't expand `$SSH_AUTH_SOCK` on Unix. However, this only affects users with `ignoresshconfig=true` since normal people would use findSshConfigKeywords() which correctly resolves the env...

📝 Add docstrings to `feat/ssh-agent-windows`

plz close this PR, thanks.

[Feature]: Add Windows SSH agent support

Hi @rodalpho I tested this on Wave 0.13.1 with the 1Password SSH agent, which works smoothly for me. To help narrow this down, could you share a bit more detail?...

[Feature]: Add Windows SSH agent support

Hi, Much thanks for your details. So sorry that it seems the wave team and I didn't add agent communication logs to the client. I just tried a fresh setup...