Andy Goryachev

Results 502 comments of Andy Goryachev

Thank you @kevinrushforth . I just wanted to emphasize that unlike any other feature that goes into mainline, this module is an incubating module, with the primary goal of getting...

> "editable" does in `RichTextArea` I see your point. Let me see how we can make this clearer (I also welcome naming suggestions).

follow-up: 1. RTA::canEdit() will be removed to avoid confusion. 2. will change to StyledTextModel::writable

> This method seems redundant: `fromInlineStyle(style)` and `fromStyles(style)` are equivalent. Do we need both? These are not the same. `fromInlineStyle(String)` accepts as single string containing fx-style CSS with one more...

> It looks like you copied, rather than moved yep, thanks for noticing!

> So, do we really need `fromInlineStyle`? Now I understand the question! A bit of history: I had a single method before that accepted `(String style, String ... names)`. Turns...

> `fromInlineStyle` docs that it is equivalent to `fromStyles(style)`. good point, thanks! edit: actually, these are hidden behind RichParagraph.Builder methods, so they can be made package-protected. Also, StyleAttributeMap.fromTextNode() can be...

> but not to third-party controls Does it mean you propose to make the `Event.propagateConsume()` method public?

> This PR assumes that during dispatch events are copied using copyFor. But the documentation states that an EventDispatcher can do whatever it wants in `dispatchEvent`. A developer could provide...

@beldenfox : EventUtil is not a public API. Checking the return value of the dispatchEvent is, in my opinion, an anti-pattern. The right pattern is this (TabPaneBehavior:85): ``` public boolean...