Andy Goryachev

Results 225 comments of Andy Goryachev

> hmm ... where are the tests ;) good point. will do.

26 minutes since the last push, github does not see the changes. what gives?

> A small comment about the memory test with [JMemoryBuddy](https://github.com/Sandec/JMemoryBuddy). Thank you for suggestion. I will definitely use it in other tests! Here it won't work because in the part...

@FlorianKirmaier : I am not sure if using JMemoryBuddy.memoryTest results in a clearer or more concise code, given the nature of testScrollPaneObjLeakWhenUsedSameContent(). BTW, MemoryTestAPI names are a bit confusing: "assert*Collectable"...

Dear @kleopatra : thank you for insightful comments and suggestions! I do agree that, in general, it might be beneficial to have one test case per condition or failure, but...

Dear @kleopatra : Thank you so much for the wisdom. Let me try to refactor the test cases. A few questions: 1. StageLoader - since it is being disposed of...

addressed feedback from @kleopatra : - implemented direct tests: TreeTableRowTest, TableRowTest - properly using StageLoader - tree table tests fail with the current master, pass with this PR. also, tree/table...

I give up - removing TreeAndTableViewTest. Thank you @kevinrushforth for insights and suggestions!