Andy Blum

Results 48 comments of Andy Blum

We're definitely adding nodes with the new navigation. There's a considerable amount more complexity

@RichKummer Those changes are definitely not coming from this PR - we'll need to investigate where that's coming from, but those screenshots _also_ don't match up with the V2 masthead...

https://babeljs.io/docs/en/babel-plugin-syntax-dynamic-import > NOTE: This plugin is included in @babel/preset-env, in [ES2020](https://github.com/tc39/proposals/blob/master/finished-proposals.md)

@IgnacioBecerra Can you rebase this onto `feat/masthead-v2` to pull in the v2 story & other updates?

I had too many problems rebasing this, so I manually duplicated the changes to a new PR, #9602

@justinfagnani - Is there any chance the PR linked above could get back-ported to this repo? Our team is still running on `lit-element@^2.5.1` and we're hitting this issue.

I'm not 100% sure why we haven't upgraded, it may be in progress and it's just a long, deliberate process to ensure backwards compatibility. A minor/patch upgrade would likely be...

A very simple workaround here is to modify the end of the file: ```js /** * export the module via AMD, CommonJS or as a browser global * Export code...

Codepen for verification: https://codepen.io/andy-blum/pen/eYoPJOO/26189acfec3414ad0afc9ac6831f7f23

Oh that's a great question. Let me find out when we plan on upgrading to v2.