carbon-for-ibm-dotcom icon indicating copy to clipboard operation
carbon-for-ibm-dotcom copied to clipboard

test(masthead-v2): add e2e tests for masthead v2

Open andy-blum opened this issue 2 years ago • 5 comments

Related Ticket(s)

Followup to #9570

This PR branches off of the above PR, and should not be added in first.

Description

  • Duplicates & adapts the masthead (v1) e2e tests to cover masthead (v2).
  • Adds a desktop/mobile test to check for Google Analytics attributes

Changelog

New

  • Add masthead-v2 test coverage

andy-blum avatar Oct 19 '22 17:10 andy-blum

Deploy preview created for package React: https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/9573/index.html

Built with commit: 68eeb4086d62fe664454fbcb357a0070f9d350d2

ibmdotcom-bot avatar Oct 19 '22 17:10 ibmdotcom-bot

Deploy preview created for package Web Components HTML Test Application: https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9573/index.html

Built with commit: 68eeb4086d62fe664454fbcb357a0070f9d350d2

ibmdotcom-bot avatar Oct 19 '22 18:10 ibmdotcom-bot

Deploy preview created for package Web Components (React wrapper): https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9573/index.html

Built with commit: 68eeb4086d62fe664454fbcb357a0070f9d350d2

ibmdotcom-bot avatar Oct 19 '22 18:10 ibmdotcom-bot

Deploy preview created for package Web Components: https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9573/index.html

Built with commit: 68eeb4086d62fe664454fbcb357a0070f9d350d2

ibmdotcom-bot avatar Oct 19 '22 18:10 ibmdotcom-bot

Deploy preview created for package NextJS Test Application: https://ibmdotcom-nextjs-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/9573/index.html

Built with commit: 68eeb4086d62fe664454fbcb357a0070f9d350d2

ibmdotcom-bot avatar Oct 19 '22 18:10 ibmdotcom-bot

Hey Andy, I took a look at the Percy snapshot and it looks like the PR updated the type token for the menu headers. Sharing here so you can see:

PR 9573 - Masthead type token update

RichKummer avatar Oct 26 '22 20:10 RichKummer

@RichKummer Those changes are definitely not coming from this PR - we'll need to investigate where that's coming from, but those screenshots also don't match up with the V2 masthead data.

andy-blum avatar Oct 28 '22 14:10 andy-blum