Andrea Selva

Results 256 comments of Andrea Selva

## Analysis of removal of Preventive GC flag on Logstash ### Definition of which problem preventive GC was intended to resolve JDK 17 introduced the flag `G1UsePreventiveGC` to resolve a...

Reopen because inadvertently closed by #15719

The test has been silenced temporarily on Windows with issue #15768 and PR #15843

@yaauie this is ready for another review :-)

> It would be helpful to know under which conditions these empty 1.log / 2.log etc. files are actually created Empty files shouldn't be created. DLQ creates a `.log.tmp` file...

The difference between the two stack traces, is that the one provided in #14599 ``` java.nio.Buffer.position(java/nio/Buffer.java:293) java.nio.ByteBuffer.position(java/nio/ByteBuffer.java:1094) java.nio.ByteBuffer.position(java/nio/ByteBuffer.java:262) org.logstash.common.io.RecordIOReader.consumeBlock(org/logstash/common/io/RecordIOReader.java:184) org.logstash.common.io.RecordIOReader.consumeToStartOfEvent(org/logstash/common/io/RecordIOReader.java:238) org.logstash.common.io.RecordIOReader.readEvent(org/logstash/common/io/RecordIOReader.java:282) org.logstash.common.io.RecordIOReader.seekToNextEventPosition(org/logstash/common/io/RecordIOReader.java:156) org.logstash.common.io.DeadLetterQueueReader.seekToNextEvent(org/logstash/common/io/DeadLetterQueueReader.java:87) org.logstash.input.DeadLetterQueueInputPlugin.setInitialReaderState(org/logstash/input/DeadLetterQueueInputPlugin.java:95) org.logstash.input.DeadLetterQueueInputPlugin.lazyInitQueueReader(org/logstash/input/DeadLetterQueueInputPlugin.java:74) org.logstash.input.DeadLetterQueueInputPlugin.register(org/logstash/input/DeadLetterQueueInputPlugin.java:81) ``` started in DLQ...

I've tried to reproduce locally with fresh installation of `7.17.8` and creating empty segment files, and the reader doesn't crash. ## Test setup - download tar.gz distribution of `7.17.8` and...

> The files that script creates bear no resemblance to the files I have My bad, you are right, DLQ saves the 1 char value and not the 1 integer...

I've updated the gist to create the segment files with the 1 character instead of the number.