Andrzej Stencel

Results 160 comments of Andrzej Stencel

Should this PR be marked with the `Skip-Changelog` label? Or is it worth adding this change to the Changelog?

Here's the simple pull request implementing the change: https://github.com/open-telemetry/opentelemetry-collector/pull/5626. I was worried that access to logger is not possible at this stage with the refactoring made in service/collector.go, but it...

Fixed by https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/12802.

Thanks @jspaleta for writing this up. Here's the proposal to add the first metric (page faults) to the semantic conventions spec: https://github.com/open-telemetry/opentelemetry-specification/issues/2809.

I believe this is a reasonable request. I think a new `system` scraper could be created to provide general system information like uptime and other information (to be honest no...

Oops only now have I noticed that there's a similar convention already in place in the `system` namespace. The metric name is `system.paging.faults` with the `type` attribute of `major` or...

I'll take no comments as good news and will prepare a pull request to add `process.paging.faults` metric with a `type` attribute of `major` or `minor`. I will not add the...

What needs to happen for this pull request to be merged? (Other than me updating the branch again)

Thanks ~~Dan~~ Tigran :facepalm:, didn't see this issue. It is closely related. It talks about `process` namespace and not system, but I think the discussion can be applied to system...

We discussed this briefly during today's SIG Spec call, let's see where the conversation in #1273 takes us.