Andrew Johnson
Andrew Johnson
> It would be possible, but I don't think that is an easy change in the current test infrastructure, since `make` doesn't tell you when _some_ targets are done. I'd...
> Requesting changes to the types for readability. Please don't overuse auto. It makes it hard to understand what's going on with the code. Thanks @syclik! Updated to more explicit...
@syclik small ping to have a look at the review responses here
I think this is correct, as the second derivative of `pow(x, y)` w.r.t. `x`: $$ \frac{d^2}{dx^2}(x^y) = x^{(-2 + y)} \cdot (-1 + y) \cdot y $$ Is not defined...
Ah I see, we handle this in the `rev` header by skipping the partials update. Thanks for catching this!
Covered as part of #3031
I'm finding this will be better as an internal function for just `grad_pFq`, since it needs to track the sign of the returned sum as well. Will close for now
Re-opening this since I'm finding it's needed for other functions which aggregate on the log-scale but still track the sign
Thanks for opening this @jaburgoyne! I'm working on the numerical stability of a few of the LCDF's at the moment, so I'll tackle this as well
> What is the motivation for using fvar in the ODE? I've just been running the new `hessian()` method in `cmdstanr` across a bunch of example models to check for...