Andrew Johnson
Andrew Johnson
Was slightly derailed by rstan and rstanarm CRAN prep, I'll have this updated by tomorrow
@Franzi2114 this is just about good to go, but there's a test hang in `rev/prob/wiener_full_test` that I can't replicate locally in MacOS or linux. Would you mind checking out the...
> @Franzi2114 this is just about good to go, but there's a test hang in `rev/prob/wiener_full_test` that I can't replicate locally in MacOS or linux. Would you mind checking out...
@Franzi2114 That's the last of my changes. To summarise, I've: - Updated `hcubature` to take a tuple of parameters instead of casting structs. There's an additional simplification available by having...
@Franzi2114 Ah hold on, there's something a bit off with your construction of the `wiener_full` likelihood here: ```cpp for (size_t i = 0; i < N; i++) { // Calculate...
Makes sense! I'll update that now
@SteveBronder did you still want me to take a look at this, or is it all covered by @syclik and @t4c1?
> @andrjohns if you have some time to look at this it would be great! But also imo I think this would be a major version bump so we should...
> @syclik @andrjohns fixed the merge conflict, all good for me to merge to 5.0? Yep, all good from me
> I think for arm it makes sense but idt we need it for other systems Sounds good to me! Will open a PR in a tick