Dzung Nguyen
Dzung Nguyen
Yes, I'd love to have the code merged. Besides names, should I add test cases or anything else?
@grlee77 I updated with docstrings and fixed PEP8. I will put more test cases and examples in 2-3 days. How could I run the specific tests for steerable only? For...
@grlee77 I finished the code based on your reviews (fixed format, added docstrings, added multiple test cases and one example in doc folder). Could you please look again at the...
@grlee77 I rebased, and waiting for the checks to complete.
@grlee77 All checks have passed. Could you please have a look at the PR again?
@grlee77 I updated PR based on your reviews and added lots of test cases. All check see have passed.
@grlee77 Could you please have a look at the PR again? Let me know if anything else should be added.
@grlee77 Updated tests with stricter agreement, except for asymmetric cases which can only match with 1 decimal of accuracy. Also I'm not sure why this PR fails with Python 3.4.
@grlee77 I added the checking of height. It turns out that previously, the second dimension of asymmetric shape (113,**29**) is less than 2**height (where height is 5) thus the reconstruction...
@grlee77 any updates on this? Thanks!