Andrew Sy Kim

Results 359 comments of Andrew Sy Kim

Ah gotcha, yeah that seems pretty old

Some feedback I got from an internal security review at Google (cc @mtaufen, @vinayakankugoyal): * Start with support for `audiences` in TokenReview API to avoid unintended use of tokens mounted...

@sampan-s-nayak and @edoakes suggested updating this REP to include the fulll scope of token authentication, including the k8s integration. We'll update the REP once it's ready

Agreed that introducing RBAC in Ray is something worth pursuing. I don't think we need the same set of verbs as Kubernetes though (get, list, create, update, patch, delete, etc),...

I think I misunderstood your last comment, but after speaking with Edward it seems like we should defer adding additional verbs into Ray for now and revisit it later.

Sorry for the delayed response on this, I've been mulling over it a bit since we're early in the v1.5 cycle anyways. My biggest question is whether we want this...

@edoakes @MengjinYan @ryanaoleary and I agreed on the approach to take here. Well-known default Ray labels will be set using environment variables from Ray. The value is based on the...

> A quick question, does this require code change? The code change is that we need to add these env vars using downward API in every Ray pod: ``` -...

Users still have the ability to set labels in `rayStartParams`, we're not changing anything here. > Write a doc to educate users to set rayStartParams and no code change in...

@kevin85421 you missed some of the discussions last week so maybe missing some context. But keep in mind that there are already env vars for default labels, this PR will...