Andrew Sy Kim
Andrew Sy Kim
No objections from me to defer beta graduation to v1.35 to ensure we get some initial feedback using the proper labels
> can you update PR to only change names of labels and the history update, without the stage change Done
> L174 needs an update: topology.k8s.io/* labels. Did you mean `topology.kubernetes.io/*`?
@johnbelamaric comments addressed, PTAL
@weizhaowz are you available to work on this?
@davidxia @kevin85421 thoughts on this change?
@davidxia i think so, alternatively we can have TTLs per scenario like we discussed on slack: ``` apiVersion: ray.io/v1 kind: RayJob metadata: name: .. spec: deletionPolicy: onSuccess: policy: DeleteCluster ttlDuration:...
@seanlaii thanks for the feedback -- I had thought that `ttlSecondsAfterFinished` should still be respected when using DeletionPolicy https://github.com/ray-project/kuberay/blob/v1.3.2/ray-operator/controllers/ray/rayjob_controller.go#L363-L367. If this is not the case, we should investigate that bug...
> I was wondering about the future plans for this enhancement. Based on my testing with KubeRay 1.3.2, it appears that when DeletionPolicy is used, ttlSecondsAfterFinished does not seem to...
> In both cases, the worker pods were successfully removed after the job finished, but the RayCluster remained indefinitely. I'll dig a bit deeper to see if there's an issue...