Andrew Serong

Results 149 comments of Andrew Serong

Thanks for taking this for a spin! > I was just curious if we considered a readonly flag so as not to mix types for Edit. > I can't see...

> Correction, I didn't introduce it 😅 but I assume they shouldn't be centered like this? I assume not, but that layout (`panel` and `labelPosition` of `top`) is pretty off...

> Correction, I didn't introduce it 😅 but I assume they shouldn't be centered like this? @ramonjd actually, I think removing `align-self: center` does fix it in this case (probably...

> I'll create a PR so we can debate it there. Thanks! Thanks for looking! In case it helps, here's what I was testing locally, if we still need the...

> Also tried the patch and works nicely. I've skimmed through the hosting dashboard project, and they're using the regular layout everywhere, so this patch wouldn't affect anything else that...

> For coherence with the existing ones, it should be something along the lines of enableEditing. I like this, I'll give that a go next week 👍

Update: I think this should be ready for another review now — I've updated the PR to use `enableEditing` instead of setting `Edit` to false. Overall it appears to still...

Another tiny update: I've switched the flag to `readOnly` based on the discussion in the comments: https://github.com/Automattic/wp-calypso/pull/104291#discussion_r2160648943 This aligns better with a default state of editable (so nullish or falsy...

Nice work here, it's testing well for me so far. Also a +1 for what Aaron mentioned, I'm curious about the need for the additional classnames. Sometimes when we have...