Andrew Serong

Results 75 comments of Andrew Serong

> What do you think? Hrm... this is an interesting one 🤔. Personally, I don't think block themes should get this hard-coded list of CSS rules, since the base styles...

Thanks @scruffian, this definitely feels closer! The styles appears to be output in the correct places, without the duplication in the earlier commit. Unfortunately, it looks like these base styles...

> Another option is to keep these rules but also add the CSS back to the block... Good point. That might wind up being the simplest approach for now 🤔

I'm happy to help out with Layout backports. I'm travelling at the moment but can start looking at some of them next week when I'm back. Some of them might...

Apologies for the late reply, and thanks for the discussion here! > I often find it harder to use these components than to write CSS styles myself I've found this...

> All I could find was https://core.trac.wordpress.org/ticket/46498, but there's no patch attached. It's an interesting one. From that discussion it looks like only `calc()` and `var()` were added in this...

> I think this would be great to add. Thanks for the reminder @scruffian! I was tweaking a couple of bugs over the past couple of weeks and this WIP...

I've given this a rebase, and I believe it's ready for review now 🙂

Thanks @glendaviesnz! I'll merge this in, but 🤞 we can swap over to using the new spacing controls you've merged before too long.

> The theory is that if a theme author doesn't want the core scale they explicitly set steps to 0, so it is a valid setting that will be documented...