Andrew Pollack

Results 12 comments of Andrew Pollack

Resolved by https://github.com/rust-lang/this-week-in-rust/pull/3653

Resolved by https://github.com/rust-lang/this-week-in-rust/pull/3653

Marking as resolved thanks to our amazing language-specific reviewers (see [README](https://github.com/rust-lang/this-week-in-rust#language-reviewers))

Thank you for creating this issue. Presently, we treat newsletters as read-only archived, so we will not remove this dead link

Looking into this now. I'll start by adjusting date methods at https://github.com/pola-rs/polars/blob/master/polars/polars-time/src/chunkedarray/date.rs#L31 and https://github.com/pola-rs/polars/blob/master/polars/polars-time/src/chunkedarray/datetime.rs#L56 , and moving from there

I'm trying to adjust the `cast_and_apply` function at https://github.com/pola-rs/polars/blob/master/polars/polars-time/src/chunkedarray/datetime.rs#L10-L16 to cast the resulting type into a desired type (e.g. `Int8Type`). Despite adjusting the function to take in a `desired_type`, I...

That makes sense! Revisiting, I'm adjusting each function passed to be of form: ```rust fn month_i8(array: &dyn Array) -> ArrowResult { let m32 = temporal::month(array).unwrap(); Ok(PrimitiveArray::::from_vec(m32.into_iter().map(|v| v.unwrap() as i8).collect::())) }...

Edit: Resolved! Agreed that we should avoid two vec allocation. Unfortunately my Rust knowledge is preventing me from finding a cleaner conversion from the resulting `temporal::month(array).unwrap()` as a `PrimitiveArray::` into...

@ritchie46 How should the [`pl.Date`](https://github.com/pola-rs/polars/blob/master/py-polars/polars/datatypes.py#L483) type be approached with this change? Specifically, the test at https://github.com/pola-rs/polars/blob/master/py-polars/tests/unit/test_series.py#L1919 will now have `dt.month` being of type `Int8`, but `pl.Date` evaluates by default to...

I've given an update on the draft PR #6272 , but copying here in case it's actionable to others Life circumstances have changed a bit and I do not have...