Andrew Correa
Andrew Correa
As my issue https://github.com/kaitai-io/kaitai_struct/issues/1249 was merged here, noting my PR for review https://github.com/kaitai-io/kaitai_struct_compiler/pull/320
I have read the CLA Document and I hereby sign the CLA
I have read the CLA Document and I hereby sign the CLA
@tssweeney @andrewtruong can anyone review this to close it?
@andrewtruong continuing from the comment at #5288 Your #5290 unblocks users on gql==4.x today via gql’s compatibility layer. For completeness, here’s what #5289 contributes beyond #5290 and why I’m asking...
@tssweeney @andrewtruong can anyone review this to close it?
> Hey @andrewmonostate, thanks for the PR! > > I think we resolved this here: > https://github.com/wandb/weave/pull/5290 @andrewtruong Thanks for the quick response and for #5290. A couple clarifications on...
@andrewtruong any comments?
Hey @GreyCat I have to be honest - this feels very frustrating. My PR (#320) fixed this exact issue 11 days ago, with tests and consistent escaping across identifiers. I...
Thank you for the response. A few clarifications and concrete requests: 1) “Incomplete” claim (scope) • My PR (#320) fixes the core bug by escaping reserved keywords at the identifier...