Andrew Mains
Andrew Mains
Hey @gibbscullen I'm going to reopen this; I think it's actually still an issue (unittest still fails post rebasing my branch). We happened to have a customer run into it...
Looks like the same issue as https://github.com/m3db/m3/issues/1810 -- definitely a legitimate issue. Closing as dupe.
cc @zmt I'm tracking the work overall here for public consumption.
Thoughts on this @nbroyles ? cc'ing you since I know you did a lot of work on the Go based integration tests; lmk if there's anyone else relevant to loop...
cc also @justinjc @SokolAndrey
Hey @schallert any thoughts on this, and/or cc anyone who might have knowledge/concerns? I did a bunch of PR's against an Uber specific branch to unblock things on our side;...
Uber Go style should clarify ordering for type declarations and methods in files with multiple types
Just a vote for types next to method definitions: a struct and its methods are typically very tightly coupled to each other; it's much easier to understand the methods in...
Btw I didn't see any contribution guides, but please feel free to point me to one as needed!
> Only exposing public interfaces, implementations are package-private. This is unfortunately probably backwards incompatible, and I'm not sure worth a new version. Should we back that out? cc @prateek
Validations while the build is off: - Ran local tests for this package on linux; they pass.