Andrew Lor
Andrew Lor
# Proposal ## Context `ReportActionsView.js` is listening to the change event on AppState to update the `newMarkerSequenceNumber` (essentially where the new marker should be displayed). https://github.com/Expensify/App/blob/d3120758546153d25002866f6cd770d6b2b123c2/src/pages/home/report/ReportActionsView.js#L103-L115 However, it will not...
Thanks @rushatgabhane. For the refactor, were you thinking something like this? ```javascript function isVisible() { if (window.electron && AppState.currentState !== 'active') { return window.electron.sendSync(ELECTRON_EVENTS.REQUEST_VISIBILITY); } return document.visibilityState === 'visible'; }...
@thienlnam @marcaaron After looking into this more, it seems like it's the order of events. I believe BrowserWindow.isFocused() is correct, but it is false immediately after AppState becomes active because...
@thienlnam I just pushed changes to my PR implementing @marcaaron's idea https://github.com/Expensify/App/issues/10767#issuecomment-1254354995. Have a look guys and let me know if I understood it correctly. I just figured it was...
While we're waiting for the regression period before payment, I'd like to request consideration for an increase in compensation. I feel like $1000 would be more appropriate for the work...