Andrew Lock
Andrew Lock
## Benchmarks Report :snail: Benchmarks for #5207 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/0ebc75bd80b322ab3f1f0599c58db78ff69bff1d): * 2 benchmarks are **faster**, with geometric mean 1.188 * 1 benchmarks are **slower**, with geometric mean 1.160 * 1...
Hi @marcovr, thanks for flagging this. It appears that this was [a behavior change in .NET 8](https://github.com/dotnet/runtime/issues/96227) which disables the profiling APIs we rely on when you set `COMPlus_EnableDiagnostics=0`. Unfortunately,...
Yep, makes sense - will look at getting that added somewhere - thanks! 🙂
Just FYI, we've added detection of this scenario to the `dd-dotnet` diagnostic tool - https://github.com/DataDog/dd-trace-dotnet/pull/5208 Out of interest though @marcovr/@nwesoccer _why_ are you setting `COMPlus_EnableDiagnostics=0`/`DOTNET_EnableDiagnostics=0` 🤔
## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (5191)](https://github.com/DataDog/dd-trace-dotnet/tree/4ba8e854da42f31c6661f9aff432cad8a3b51422) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/9e318750722ff76e5c9622c649f3c41358e8edf4) Execution-time benchmarks measure the whole time it takes to execute a...
## Benchmarks Report :snail: Benchmarks for #5191 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/d3b7b308d25bc3aad2198a34ba163030107a9f75): * 1 benchmarks are **faster**, with geometric mean 1.174 * 4 benchmarks are **slower**, with geometric mean 1.173 * 1...
## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (5031)](https://github.com/DataDog/dd-trace-dotnet/tree/55f2ea0ec99c6b2d982b8f0f7f33ef73da4c4d2d) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/050ef98a8f92469a3054b7af7a1370dbaf897608) Execution-time benchmarks measure the whole time it takes to execute a...
## Benchmarks Report :snail: Benchmarks for #5031 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/d34e232d80a21ad4ea591b57ecfbe36509086c36): * 1 benchmarks are **faster**, with geometric mean 1.136 * 2 benchmarks are **slower**, with geometric mean 1.166 * 1...
## Throughput/Crank Report:zap: Throughput results for AspNetCoreSimpleController comparing the following branches/commits: - [This PR (5031)](https://github.com/DataDog/dd-trace-dotnet/tree/8453bb54c9a93e85e5d5f13aaa19a2648d971908) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/6051f08cb40b9b33d5058695f88e07e190ebde05) - [benchmarks/2.9.0](https://github.com/DataDog/dd-trace-dotnet/tree/89ae3f4ee7d85b824badda5873166707c9e560b4) Cases where throughput results for the PR are worse than latest...
## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (5267)](https://github.com/DataDog/dd-trace-dotnet/tree/94afb4b53494f3bfcf99a62cebf32bcfa3f01d41) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/9419bec407a238ef7a02f1b87f53b96bf210910d) Execution-time benchmarks measure the whole time it takes to execute a...