Andrew Lock

Results 1518 comments of Andrew Lock

## Throughput/Crank Report:zap: Throughput results for AspNetCoreSimpleController comparing the following branches/commits: - [This PR (5681)](https://github.com/DataDog/dd-trace-dotnet/tree/06081541eb0d786551708969222ef6a24b16643d) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/3813df26a5dfb4f00845637274145ce58934733f) - [benchmarks/2.9.0](https://github.com/DataDog/dd-trace-dotnet/tree/89ae3f4ee7d85b824badda5873166707c9e560b4) Cases where throughput results for the PR are worse than latest...

## Benchmarks Report for tracer :snail: Benchmarks for #5681 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/9bd53398b3a0f8b3c2a32ffed1fb2cfa5dcd8060): * 1 benchmarks are **slower**, with geometric mean 1.142 * All benchmarks have **the same** allocations The following...

## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (6554)](https://github.com/DataDog/dd-trace-dotnet/tree/60b167cece3263e1fd2d9bf1a8b3409bf3772d63) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/35b0d116e41b9c2237f2e10301a035a87cebb93d) Execution-time benchmarks measure the whole time it takes to execute a...

## Benchmarks Report for tracer :snail: Benchmarks for #6554 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/35b0d116e41b9c2237f2e10301a035a87cebb93d): * 1 benchmarks are **faster**, with geometric mean 1.114 * All benchmarks have **the same** allocations The following...

Hey, sorry for the delay, I managed to miss this... did you ever get to the bottom of the issue? I've just given it a try and I can see...

Ok, I've just figured it out. Source generators _can't_ see the output of _other_ source generators. So the Json Source Generator _can't_ see the the converter generated by `StronglyTypedId`, hence...

One possible workaround is the approach I use in the tests: https://github.com/andrewlock/StronglyTypedId/blob/2313453da5db3dced61bcb99b82e9443f7f22367/test/StronglyTypedIds.IntegrationTests/SystemTextJsonSerializerContext.cs#L18-L30 This doesn't help with the `Default` case, but it does mean you can do something like this: ```csharp...

Not currently. But you could do this in your own app by creating your own template, as described in [this post](https://andrewlock.net/updates-to-the-stronglytypedid-library/) and [this issue](https://github.com/andrewlock/StronglyTypedId/issues/102) 🙂

>... This does not produce the 350 lines of code that the built-in templates generate Correct, your template has to include _everything_ you want - you could start from one...

Yes, it would😊 the same goes if you use some of the other converters or IDs that have external dependencies. This is where the templates come in, you can tailor...