Andrew Lock

Results 1521 comments of Andrew Lock

## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (5831)](https://github.com/DataDog/dd-trace-dotnet/tree/3f843d5a574c3e42ffe1dee9189a6e8867b634b3) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/fd762fb2b3ad46c01fb2cde81a93f664fee874ad) Execution-time benchmarks measure the whole time it takes to execute a...

## Benchmarks Report for tracer :snail: Benchmarks for #5831 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/fd762fb2b3ad46c01fb2cde81a93f664fee874ad): * 1 benchmarks are **slower**, with geometric mean 1.140 * All benchmarks have **the same** allocations The following...

## Throughput/Crank Report :zap: Throughput results for AspNetCoreSimpleController comparing the following branches/commits: - [This PR (5831)](https://github.com/DataDog/dd-trace-dotnet/tree/b5de11770661b4a27ffb6dfe740450d825d68a73) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/f93ed0a50650adad9a5c1aeb64afeaf3a8325b91) - [benchmarks/2.9.0](https://github.com/DataDog/dd-trace-dotnet/tree/89ae3f4ee7d85b824badda5873166707c9e560b4) Cases where throughput results for the PR are worse than...

Hi @ghidello! There's a couple of aspects to this. Hashes are certainly _better_ than nonces from a security PoV, that's true; nonces are what you need if you don't have...

> Maintaining hashes in a project is a nightmare and time consuming That's true if you can't automate it, for sure. Luckily the tag helpers make it easy 😄 That...

Great, if I understand the fix in the linked issue, then you should be able to grab the nonce generated by the library (by calling `HttpContext.GetNonce()`) and set it as...

Cool, in which case I'll close this issue for now then, thanks @ghidello!

## Execution-Time Benchmarks Report :stopwatch: Execution-time results for samples comparing the following branches/commits: - [This PR (5498)](https://github.com/DataDog/dd-trace-dotnet/tree/639a5248101c659ba31e5d3bde91a67743a886ad) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/935deec6e659e1a81d68be1043ca009d8b192895) Execution-time benchmarks measure the whole time it takes to execute a...

## Benchmarks Report for tracer :snail: Benchmarks for #5498 compared to [master](https://github.com/DataDog/dd-trace-dotnet/tree/935deec6e659e1a81d68be1043ca009d8b192895): * 1 benchmarks are **slower**, with geometric mean 1.144 * 1 benchmarks have **more** allocations The following thresholds...

## Throughput/Crank Report:zap: Throughput results for AspNetCoreSimpleController comparing the following branches/commits: - [This PR (5498)](https://github.com/DataDog/dd-trace-dotnet/tree/0c50ab09ed59ca7cecef4e01df7c083c599bd801) - [master](https://github.com/DataDog/dd-trace-dotnet/tree/0597c72442b9b7ad514cb14e2f21bf554b0ae128) - [benchmarks/2.9.0](https://github.com/DataDog/dd-trace-dotnet/tree/89ae3f4ee7d85b824badda5873166707c9e560b4) Cases where throughput results for the PR are worse than latest...