Andrew Kozlik

> * fix validation of few address types in connect > examples which should be valid: > BTC BC1SW50QA3JX3S > BTC bc1pw508d6qejxtdg4y5r3zarvary0c5xw7kw508d6qejxtdg4y5r3zarvary0c5xw7k7grplx Where did this requirement come from? I think...

The hack for adding external inputs described above is incorrect and indeed cannot work with Taproot. With the next release of Trezor firmware it will cease to work with all...

In https://github.com/trezor/trezor-firmware/pull/2507/commits/87bc82b405a895911f51d09cd87e90344e18e88f I tried changing `no_serialize` to `serialize` and the default to `true`. This change breaks device tests as well as unit tests. There seems to be something very wrong...

> Indeed, there seems to be a [bug in `pb2py`](https://github.com/trezor/trezor-firmware/blob/master/common/protob/pb2py#L641) where it expects the value to be a capital-T `True`. I'd need to check but I guess that shoud either...

> > I tried to optimize the Python implementation, but it didn't help and I couldn't locate any particular operation that is responsible for the huge time difference. > >...

I am not sure whether you see this @invd in the GitHub checks: ``` [CLANG-FORMAT] ./crypto/fuzzer/fuzzer.c ... 5 changes needed make: *** [Makefile:73: cstyle_check] Error 1 Error: Process completed with...

@szymonlesisz also noticed that the SLIP-25 path does not match the coin name in `test_get_public_key()`. Fixed in https://github.com/trezor/trezor-firmware/pull/2517/commits/291622ec51dd67bf4d607aa35386adddc3aec015.

https://github.com/trezor/trezor-firmware/pull/2517/commits/f333fdb53d40845b916957e788f92eee65555214: Added support for SLIP-25 accounts in `trezorctl` commands `get-public-node` and `get-address`. I am not sure how to deal with `get-descriptor`, because one can't specify a SLIP-25 account. I suppose...

> I believe we don't need changelog because there has not been a release in the meantime, right? The last commit https://github.com/trezor/trezor-firmware/pull/2517/commits/1d114c6fd8cf8ea26dd0565e3cf05b64771b017d deserves a changelog. Added just now.

> I made changes suggested by @prusnak , but I'm still getting `ERROR: Altcoin strings found in Bitcoin-only firmware.`. 178d06b597134cc3f7fd81ada1be9952d2dc4c19 should fix it. > If we do the change above...