Andrew Kolos

Results 74 comments of Andrew Kolos

> What is the status of this PR? Should we close it? Yes. (tools PR triage happens to happen tomorrow, but I can do this now). @SNNafi Heya! This PR...

Still waiting for this to flake again.

Sorry, this PR fell off my radar. I will be closing it since I lack the bandwidth to work on it—I'm giving priority to current tool crashes.

Something I forgot to add is that this can happen even with non-zero-length recording sessions, as long as the duration is short enough. For example, calling `stop` ~50ms after `start`...

> No rush, the google3 changes required for this to land are blocked on Dart CLI support in google3, so I'm not sure how long that'll take to clear up....

Here is a recent failure (5/4): https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_3_4/16348/overview and a quick link to one of the flaky tests: https://github.com/flutter/flutter/blob/13beab1ecccf52993ae6bfcce4150fa4d3b734f2/packages/flutter_tools/test/integration.shard/vmservice_integration_test.dart#L77 From the logs, it seems we get to stuck somewhere in [`HotRunner::_restartFromSources`](https://github.com/flutter/flutter/blob/023d4cc50e0b4baacbbaeb23c1acb03d4cc5101d/packages/flutter_tools/lib/src/run_hot.dart#L609)....

With https://github.com/flutter/flutter/pull/147997 landing, we are getting some new information here. Here is an [example](https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20tool_integration_tests_3_4/16436/overview) ([quick link to logs](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748427602248098929/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_3_4/stdout)). In the logs, we see we get far enough to print `Finished...

> The only long-running/async operation I see within is [_launchInView](https://github.com/flutter/flutter/blob/2cfae1431f70d7f04ed167d06514dc68cce8a359/packages/flutter_tools/lib/src/run_hot.dart#L580), which in turn makes two VM service calls, [_flutter.listViews](https://github.com/flutter/flutter/blob/2cfae1431f70d7f04ed167d06514dc68cce8a359/packages/flutter_tools/lib/src/run_hot.dart#L585) and [_flutter.runInView](https://github.com/flutter/flutter/blob/5d1bfdcb877d491f08d4a8ab94dcb3877d883116/packages/flutter_tools/lib/src/vmservice.dart#L568). However, I don't see either of these outgoing calls...

From the [logs of a recent failure](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8747982983209850113/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_3_4/stdout), I see `Finished _flutter.runInView`, but I do _not_ see `Finished running /main.dart.dill in view _flutterView/0x7f8fc781e420...`. I believe the tool is getting stuck here...

Downgrading to P1 since flakiness is under the 2% treshold.