Andrew Kolos

Results 74 comments of Andrew Kolos

If this were to be implemented, how should we handle output file naming? Say we are doing an export for a single format. Using the CLI, we specify a full...

I'd be happy to implement this feature but would like some guidance on the above. I personally am biased to having the new option flag, `-d`.

> I think C:\Users\Me\Desktop\hello could be interpreted as a file, and C:\Users\Me\Desktop\hello\ as a folder. This has an obvious disadvantage: Too little margin of error This is something I did...

Now that I think about it again, I am not sure the `\` approach is super sound. Unless we make this change only effect multiple-format exports, it would change how...

I was able to reproduce this on the master channel (8a21acc7d5). [Repro](https://github.com/andrewkolos/flutter_issue_demos_2/tree/main). I'll do some investigation.

@kenzieschmoll Where are the image assets stored within the `perfetto_compiled` directory/package? If I'm reading the [Asset images in package dependencies](https://docs.flutter.dev/development/ui/assets-and-images#bundling-of-package-assets) section in the docs correctly, the way to include assets...

> Specifying the full asset paths for files under packages/perfetto_compiled/ builds successfully. Taking a look at the docs again, I think I was confused. I think what you described here...

Sorry, I completely missed the notification for this. > So if I were to specify the perfetto_compiled assets in `perfetto_compiled/pubspec.yaml` could I think include them in `devtools_app/pubspec.yaml` as such? >...

The pubspec files look fine, but how are you loading the image within `devtools_app`? Using this from my previous comment, I am able to get the image to load. >...

Small amendment to my previous two comments. In the setup we are using, `demo_app` doesn't need to explicitly declare assets from `perfetto_compiled`, because `perfetto_compiled` already declares them. That is, as...