Andrew Kolos

Results 74 comments of Andrew Kolos

> @ditman can you help with this PR, or route to someone for web? Friendly ping @ditman

@gspencergoog Do you happen to recall why `--empty` deletes the test directory? Code here: https://github.com/flutter/flutter/blob/5a63b1df955bba1939bd7eab2bced5fe016ca429/packages/flutter_tools/lib/src/commands/create.dart#L454-L459

Is this vulnerable to the [staleness concerns](https://github.com/flutter/flutter/pull/111392#pullrequestreview-1117693406) you had with https://github.com/flutter/flutter/pull/111392?

Similarly to earlier attempts in this thread, I failed to repro. Here are my steps (on master): 1. Create a new flutter project using `flutter create web_icon_test && cd web_icon_test`...

> Is this ready for review? I'm noticing two tests that are failing but they could be flakes? Yup. These were devicelab issues

`AssetManifest.bin` is a special file that is generated on build. When the framework performs its first asset load (your image in this case), it first loads this file. I can...

I'll go ahead and change the file extension of `AssetManifest.bin` to hopefully resolve this issue, though it might take a few days since this will involve some changes to g3.

> It also happens when I'm executing unit tests that use a DefaultAssetBundle, ... @eerive @spkersten, this seems like a separate issue (though it is related to same change that...

Filed cherry-pick request to get a fix into the stable release: https://github.com/flutter/flutter/issues/126839

@garrettlove8 Do you have Internet Download Manager installed? If so, the issue shouldn't be limited to tests. If not, then your issue is not related to this one. Either way,...