Andrew Godwin comments

Results 369 comments of


                                            Andrew Godwin

Adding ASGI support?

I'm in the process of overhauling the ASGI spec to make a lot more sense for servers anyway, so I'd caution about doing anything until that's finished (new spec is...

Adding ASGI support?

@sirex ASGI is stable now. I'm not sure if you are saying that daphne does or does not adhere to the spec?

Adding ASGI support?

I haven't moved to make ASGI a PEP since I want to make sure it has enough general support first (and that process takes a lot of time and effort),...

Add Flama to implementations.rst

Could you either put this at the bottom or order all the entries alphabetically?

async_to_sync does not use the correct thread when used as decorator

This is interesting because I personally do a lot of `async_to_sync(coroutine)()` style code so I probably didn't notice this myself! PR looks good - one linting issue that needs fixing...

Clarify `raw_path` Definition for WebSockets Protocol in the Specification

I do not believe that was intentional - my guess is that we specifically clarified it for standard HTTP but not for WebSocket. I would say we should update the...

Add `offset` and `count` to Path Send

That's a good idea - `extensions` entries were meant to be dicts exactly so we could definitely add signal in there.

`asgiref.local.Local` creates reference cycles that require garbage collection to be freed when executed in a sync context

Which version of `asgiref` is this against? There is a potential fix for this in `main` that has not yet been in a public release.

ASGI TLS extension

The spec was contributed by someone else so I'm afraid I can't speak to the intent, nor did I implement it. What's the specific technical problem - client_cert_name can't be...

ASGI TLS extension

I'm happy to consider PRs to modify the TLS spec - obviously we'd have to work out who has implemented it as-is, since making fields optional for servers to provide...