Andrew Godwin

Results 206 comments of Andrew Godwin

So what needs doing here - clarification in the spec and also a fix to `WsgiToAsgi`?

OK - I won't be able to get to either in the short term, but will leave this open to track the work.

Hmm, is there a reason to not raise a known error if you `send` down a disconnected connection? I know we could just as easily make it vanish into the...

@tomchristie Do you think there's more work we need to do here?

Gosh, that's a lot of spec to cover. I think a good first move here would be to implement a prototype server and play with the message format a bit...

There is not yet - I'll leave this open for implementation as a feature. Patches are, of course, always welcome.

I'd just go with whatever we can easily get from the Python logging module and that is relatively easy to let the user configure. What exactly that ends up being...

That's generally because you are going to be receiving more than just `lifespan` events, and to allow forwards-compatibility if we add more message types (e.g. imagine we added `lifespan.pre-startup`). `receive()`...

When you write an app, you have to handle all specs combined, as you have a single main loop - you'd almost never _just_ write a lifespan app, you'd probably...

Oh, you're right, sorry - the loop should be _outside_ the if statement there. That does need fixing!