Andrew comments

Results 212 comments of


                                            Andrew

Implemented Model Reader for CMFGen example (Also refactored Stella Reader)

@wkerzendorf this should be reviewed and merged alongside the work you have been doing I think

Implemented Model Reader for CMFGen example (Also refactored Stella Reader)

@atharva-2001 needs the stella changes removed and comments addressed (ideally). Tests would also be great.

Grotrian diagram IPyWidget functionality

Can this be merged?

Grotrian diagram IPyWidget functionality

Just one conflict to resolve! Probably due to file renames recently.

Convergence plot correction: Use step plots

> Maybe someone else knows, but is 'hv' or 'vh' correct? > > Each shell is defined by an inner and outer velocity, so does the temperature, etc. correspond to...

Convergence plot correction: Use step plots

It looks like the convergence plot tests are failing, and `black` needs to be run on the code.

Add a new file parser option for non-homologous expansion

Would it be possible to add a test to this?

Add a new file parser option for non-homologous expansion

This seems to be the basis for PR 2380, is that correct?

[GSOC] Benchmarking and Performance Improvement: objective 1

Please provide graphical output and how you achieved the output

[GSOC] Benchmarking and Performance Improvement: objective 1

Thanks for the images! Please refer to this pull request in your application.