tardis
tardis copied to clipboard
[GSOC] Benchmarking and Performance Improvement: objective 1
:pencil: Description
Type: :🌞 GSoC
| :rocket: feature
PR on first objective of idea TARDIS Benchmarking and Performance Improvement
GSOC'24.
Added 2 benchmarks for SDEC plotter using Matplotlib and Plotly. Observed Plotly is much faster than Matplotlib.
Implemented by first running run_tardis then benchmarking the SDEC plotting using libraries Plotly(generate_plot_ply) and Matplotlib(generate_plot_mpl) on the output of run_tardis.
:pushpin: Resources
:vertical_traffic_light: Testing
How did you test these changes?
- [ ] Testing pipeline
- [x] Other method (describe)(Ran the program and observed results)
- [ ] My changes can't be tested (explain why)
:ballot_box_with_check: Checklist
- [ ] I requested two reviewers for this pull request
- [ ] I updated the documentation according to my changes
- [ ] I built the documentation by applying the
build_docs
label
Note: If you are not allowed to perform any of these actions, ping (@) a contributor.
*beep* *bop*
Hi, human.
I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.
Please add your name and email to .mailmap
in your current branch and push the changes to this pull request.
In case you need to map an existing alias, follow this example.
Please provide graphical output and how you achieved the output
Please provide graphical output and how you achieved the output
Done I accidentally closed this pull request. I've reopened it now. Sorry for the inconvenience
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.17%. Comparing base (
20b2a64
) to head (f31b95a
). Report is 10 commits behind head on master.
:exclamation: Current head f31b95a differs from pull request most recent head 8f42743. Consider uploading reports for the commit 8f42743 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #2547 +/- ##
=======================================
Coverage 68.17% 68.17%
=======================================
Files 166 166
Lines 14135 14135
=======================================
Hits 9636 9636
Misses 4499 4499
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the images! Please refer to this pull request in your application.
What command did you run to produce the asv web output? How long did it take to run the benchmark? Why did you choose the number of commits that are shown in the plot?
Are you applying for the shorter or larger project? If the larger, please produce the memory profile as requested. That can be a separate PR.
What command did you run to produce the asv web output?
first collected hash of last ten commits, then implemented this commands
asv run HASHFILE:tag_commits.txt
asv publish
asv preview
How long did it take to run the benchmark?
10-15 mins
Why did you choose the number of commits that are shown in the plot?
I have benchmarked last ten commits. since they depends on the speed of libraries Matplotlib and Plotly, I concentrated on comparing both the methods.
Are you applying for the shorter or larger project? If the larger, please produce the memory profile as requested. That can be a separate PR.
I am mainly interested in the topic benchmarking. And Yes, I will produce another PR on memory profiler, thank you!