Andrew Bird

Results 302 comments of Andrew Bird

I'm looking at clearing up a few more Coverity warnings and looking at DOS_HELPER_GET_UNIX_ENV. I don't seem to see any callers of it, but its implementation suggests that on entry...

I have a couple of references to uninitialised data to fix in ports.c. What should I be setting pr.word to? ![Screenshot_2024-07-11_12-27-21](https://github.com/dosemu2/dosemu2/assets/220835/29664526-8fb2-4d5a-9657-3ae57d7c9674)

It seems to have the same problem as Coverity in that after `leavedos()` it continues processing and finds errors. I did try to teach Coverity to treat that like `exit()`,...

There seems to be a Clang specific attribute `__attribute__((analyzer_noreturn))`, I'll try that.

Oh, so I'll look again at what I believed were false positives. Thanks!

So if `leavedos()` returns, is this a real problem? ![Image](https://github.com/user-attachments/assets/12c4c28f-0a3f-4efe-9788-8c6f487ede1d)

@bartoldeman did you get a chance to try rebasing my ci-12 QEMU FPU test branch on top of your FPU work? I did it locally rather than in Github Actions...

Perhaps it would help to setup Coverity static scanning from Github?

I did set it up once for dosemu once, but it will take quite some effort to make dosemu pass the checks cleanly