Andrew Fleming
Andrew Fleming
> ...I will say that I don't mind if this functionality is added by default in Ownable. It gives the user of Ownable a choice to use either one-step or...
> No worries! Let's keep this on standby for now :) thanks for your help so far with this! My pleasure, and thank you!
Hey, @ctrlc03! So when there's conflicts in a PR, it's a good idea to checkout that branch, `git merge`, and fix the conflicts. It might make sense to just make...
Hey, @koloz193! Just checking in. Will you be able to address the requested changes in the next few days? No pressure! If you can't get to it, we'll pick this...
Hey @koloz193, thank you for submitting this PR! I know you're aware that we're considering some changes to the library (#267 and you mentioned in your comment^). Once we get...
@koloz193 ahh yeah, the rebasing conflicts must have looked like a nightmare
@koloz193 Ownable is merged! I appreciate your patience, sir 🙏 at your leisure, would you mind updating your branch?
Hm yeah, I agree. I suppose if later on we decide to include it or some mention of it, we can just point to the proposal in Shamans
> > Looking good, @ericnordelo! I left a couple questions and one tiny suggestion. Also, do you think we should document the tx query feature in the Accounts docs? >...
The CI only pushes the version update to the main branch. It should also push to the tag.