André R.

+1 w/o cleanup, cleanup adds somewhat risk, and obfuscate the git history any time in the future when we need to do a blame. If we planned to make a...

And thanks for the split, was much easier to do a review now and the change makes perfect sense. Lest hope that one alone does not cause to many regressions...

And this is the problem with (missing) layers in legacy.. For the most part use of eZSearch is done outside of persistence classes, like for instance in operations classes: https://github.com/ezsystems/ezpublish-legacy/blob/master/kernel/content/ezcontentoperationcollection.php#L1011

Seem to be a copy pasty issue, the process() function uses $view_dir consistently, while this should use $viewDir Kernel don't seem to be affected by this, could only see two...

@pbek Seems there is a conflict here now after https://github.com/ezsystems/ezpublish-legacy/pull/1417, is this still needed?

ok, would you be able to rebase @pbek ?

@pbek Is the update her ok with you? And is there a JIRA issue for this?

@pbek ok, can you add one with info on when you encountered this so we have it for anyone looking up similar case?

Dropping from 2019.03 milstone until it is clear what this actually fixes.

I'm not sure I remember the details right, but I think we changed it to write a file to avoid cache_ttl=0 taking down the servers, I might mix up with...