ezpublish-legacy icon indicating copy to clipboard operation
ezpublish-legacy copied to clipboard

fixed fatal error in eZUserType::objectAttributeContent

Open pbek opened this issue 6 years ago • 9 comments

Fixed a fatal error in eZUserType::objectAttributeContent because user object could not be loaded

pbek avatar Oct 24 '18 08:10 pbek

Opening curly brace needs to go on own line

done

pbek avatar Oct 24 '18 09:10 pbek

Unrelated to the fix, but isn't it odd that hasObjectAttributeContent() will return false if the user exists but is disabled? https://github.com/ezsystems/ezpublish-legacy/blob/c306576fbc39644bbda26d9fd0f29eba82fc5e77/kernel/classes/datatypes/ezuser/ezusertype.php#L347

glye avatar Oct 29 '18 09:10 glye

@pbek Seems there is a conflict here now after https://github.com/ezsystems/ezpublish-legacy/pull/1417, is this still needed?

andrerom avatar Mar 11 '19 15:03 andrerom

I can't see this anywhere fixed in #1417, so I guess this is still needed.

pbek avatar Mar 11 '19 16:03 pbek

ok, would you be able to rebase @pbek ?

andrerom avatar Apr 02 '19 14:04 andrerom

@pbek Is the update her ok with you? And is there a JIRA issue for this?

andrerom avatar Apr 29 '19 19:04 andrerom

Looks ok to me.

And is there a JIRA issue for this?

Not that I know of.

pbek avatar Apr 30 '19 03:04 pbek

@pbek ok, can you add one with info on when you encountered this so we have it for anyone looking up similar case?

andrerom avatar Apr 30 '19 13:04 andrerom

Dropping from 2019.03 milstone until it is clear what this actually fixes.

andrerom avatar May 14 '19 11:05 andrerom