André R.
André R.
+0.8 More something for @dpobel to review
looks good, just one more cs comment open, I updated it to specify what I implied, up for it before we go ahead and create issue + squash and update...
Ok, looks ok. remain part is create an issue, rebase the branch to squash commits into one referring to the issue and force push and you should be done :)...
Hi Alex! Would it be possible to align this with ezgmaplocation code? As in use the sensor setting from ini and such.
@dfritschy Could you rebase the work on latests 1.9 so we can verify that the tests passes?
@dfritschy Sorry, but the failure seems to be relevant: > Exception: Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "ezxmltext.graphql.resolver" has a dependency on a non-existent service "ezpublish.fieldType.ezxmltext.converter.html5". in /home/travis/build/ezsystems/ezplatform-xmltext-fieldtype/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:31
Maybe not in it's current form. We might need to look at this from feature perspective instead to see how we'd approach this.
review ping @lserwatka @yannickroger
Kind of like the idea. Even though I assumed autosearch ment it looked up ezgmaplocation table and gave you a dropp down of existing addresses before I looked at the...