ezcomments icon indicating copy to clipboard operation
ezcomments copied to clipboard

Published 20 hours ago • verified publisher icon ezsystems

Fix EZP-21450: gallery-base64-min.js not avaiable on https

Open mikaelcom opened this issue 11 years ago • 8 comments

The script http://yui.yahooapis.com/gallery-2009.12.08-22/build/gallery-base64/gallery-base64-min.js is not reachable on https protocol that can be blocking. So we host the script and load it locally if the current website uses the https protocol.

Issue: https://jira.ez.no/browse/EZP-21450

mikaelcom avatar Aug 24 '13 07:08 mikaelcom

Hi Mikael and thanks for the contribution!

This fix makes perfect sense from a functional standpoint. I am not 100% sure about the implementation (JS-only), but can't find a use-case where this would fail.

+1

PS: do you happen to know whether there as a reported issue for this? If not, it would be ideal to report this here.

nfrp avatar Aug 26 '13 08:08 nfrp

Hi, I pushed this update as I encountered the issue recently. I thought that pushing a fix would be sufficient at least to open the debate on how to solve the issue. Do I need to report the issue on Jira? If so, I don't have any account on it... How do I do?

mikaelcom avatar Aug 26 '13 08:08 mikaelcom

Hi Mikael,

Pushing a PR is fantastic already!

Having an associated JIRA issue is great for tracking, and makes change-logs very easy to decrypt for the community. Here is an example: http://share.ez.no/downloads/downloads/ez-publish-community-project-2013.07/changelog-from-community-project-2013.06-to-community-project-2013.07

In order to log-in on jira.ez.no, you can use your share.ez.no account. If you do not have one, you can very easily and quickly create one by clicking the Register link in the top-right corner of the eZ Publish Community Portal.

Cheers!

nfrp avatar Aug 26 '13 08:08 nfrp

Pull request for EZP-21450

mikaelcom avatar Aug 27 '13 08:08 mikaelcom

Great, thanks for reporting the issue!

:+1: on my end.

What do you guys think @dpobel @andrerom @lolautruche @bdunogier @yannickroger ?

nfrp avatar Aug 27 '13 10:08 nfrp

+0.8 More something for @dpobel to review

andrerom avatar Aug 27 '13 15:08 andrerom

Hi Mikaël,

Thanks for the pull request. That's indeed a real issue but your patch won't work if eZ Publish is installed in a sub-directory (http://example.com/ez-subdir/).

To avoid this issue, I would rather pass the path to the local version in parameter of the init method so that this path can be computed in a template with ezdesign() for instance.

Cheers

dpobel avatar Sep 09 '13 12:09 dpobel

@dpobel Indeed I hadn't thought of the case of a sub-directory. I didn't fully understood your solution but I think you know what you mean.

mikaelcom avatar Sep 09 '13 12:09 mikaelcom