André Rösti

Results 30 comments of André Rösti

Closing this as it's not a critical issue, there's been no activity, and the branch has gotten out of date with main.

I have new found respect for you @makslevental for dealing with the mess that is Python setuptools/distutils. Not very fun. This might end up being kind of hard to make...

From my initial tests it seems like the offset is indeed expressed in bytes, but the value has to be 4-byte aligned. That is, an output like ``` 0 11...

[This validator](https://github.com/Xilinx/mlir-aie/blob/main/lib/Dialect/AIEX/IR/AIEXDialect.cpp#L67)? It currently does not seem to check offsets. Also, I believe after #1538, these [lines](https://github.com/Xilinx/mlir-aie/blob/main/lib/Dialect/AIEX/IR/AIEXDialect.cpp#L101) were forgotten to be updated. (It might be good to have a test...

I think we are having two discussions here: **(1) a bug** due to an out-of-bounds access and **(2) a discussion on the semantics** of fromStream if it is not explicitly...

I think I put it there. It made sense to me because the parser is where we create the object. It would be weird to me to have a verifier...

@jgmelber Since I cleaned up a lot of the code it may be hard to see what actually changed to make it work on multiple columns. So if you are...

Please refer to the [matrix-vector kernel I linked](https://github.com/amd/IRON/blob/devel/aie_kernels/generic/mv.cc) in your other issue for a working implementation. It should be pretty simple to port that fixed kernel to this repository and...