André Rösti
André Rösti
Hi Joel, thank you for submitting this issue, and sorry for the delayed response. I have made a number of fixes to the matrix multiplication designs since you submitted the...
This one fails even without `toStream`: ``` module { aie.device(ipu) { %tile_0_2 = aie.tile(0, 2) %tile_2_2 = aie.tile(2, 2) %tile_3_2 = aie.tile(3, 2) aie.objectfifo @a(%tile_3_2, {%tile_2_2}, 2 : i32) :...
Oh yeah, looks like the error does disappear when I use tile (1, 2). Thank you. Do you expect that link on a compute tile should work, or have you...
Thank you Andra! To give some context and motivation, my use case for this is that I have a design that is bandwidth-bound. So I need to use more channels...
Updated example: ``` module { aie.device(npu1) { %tile_0_2 = aie.tile(0, 2) %tile_2_2 = aie.tile(2, 2) %tile_3_2 = aie.tile(3, 2) aie.objectfifo @a(%tile_3_2, {%tile_2_2}, 2 : i32) : !aie.objectfifo aie.objectfifo @b(%tile_2_2, {%tile_0_2},...
Oops, forgot about this one. Yes I believe this is still needed. I can work on a test.
@fifield I finally got around to creating a fairly minimal test. I can confirm without this PR, the added test still fails on current MLIR-AIE. Sorry it took so long....
Please let me know if/when you find the root cause and if you'd still be OK with merging this PR even if it doesn't directly address the root cause.
Should we still merge this after #1936? While the error doesn't exist any more after #1936, I think it's kind of weird that this pass by default performs region simplification...