Tomasz Andrzejak
Tomasz Andrzejak
Hey @tschneidereit, while this PR is rather large, I've tried my best to keep individual commits logically separated. Each commit includes: - Enabling a specific linter group - Fixes for...
> It'd be great if you could look for those with a regex and fix them in one go. Maybe it's worth, to just run `clang format` on the codebase...
I kept my janitor hat on for a little bit longer and cleaned up `clang diagnostics` for invalid `offsetof` and disabled the warning globally with the last commit. While disabling...
Hey @tschneidereit, let me know if you wanted to have another pass on this or else maybe we can get this landed?
I will make a follow up PR where we parallelize the checks. This change is a bit controversial: https://github.com/bytecodealliance/StarlingMonkey/pull/242#issuecomment-3201119743 so I wanted to double check if you're on board to...
Did I really? 🤔 Probably a missclick, sorry for the noise.
> hi @andreiltd can i work on this seems like good first issue or do i need context ? Hey @iamrajiv , of course! Indeed it looks like a good...
Full error from repro: ``` Action failed: root//project:test (rustc link [pic]) Local command returned non-zero exit code 1 Reproduce locally: `env -- 'BUCK_SCRATCH_PATH=buck-out/v2/tmp/root/8c28631c2cb3b7ee/rustc/_buck_c5a998e79d3a718a' buck-o ...... n__/rustc_action.py @buck-out/v2/gen/root/2c621926a02f7469/project/__test__/XIPL/test-link-diag.args (run `buck2 log...
That was the issue, indeed. Thank you!