Tomasz Andrzejak
Tomasz Andrzejak
There are two pending PR that will resolve this: - https://github.com/bytecodealliance/StarlingMonkey/pull/200 - https://github.com/bytecodealliance/StarlingMonkey/pull/207 I should undraft the latter shortly. I'm investigating some test failures.
Do you mean this: https://github.com/dtolnay/cxx ? If so, yes we could then return `unique_ptr` from Rust, that would solve the issue here. BTW, I remember one of the annoyances of...
@tschneidereit Are you OK with merging this?
@guybedford @tschneidereit maybe we can label this as a `good first issue`?
Size reduction for the graph as above is marginal which is a bit surprising. I would assume it should DCE much more than this.
This should be fixed by this PR: https://github.com/bytecodealliance/StarlingMonkey/pull/249
Thank you for the patch! We had a brief discussion about it during the last JS SIG community meeting. While the functionality is definitely useful, adding just this small portion...
> Great to see this. Strictly speaking `FetchEvent` is supposed to be a subclass of this `Event`. Not sure how practical that will be though, but I think that's the...
> Strictly speaking FetchEvent is supposed to be a subclass of this Event. So this is now working as expected, for instance this code shows `FetchEvent` using `Event` interface (event.type)....
Thanks! OK, I will move this PR to draft then and try to come up with sensible lint defaults and fixes.