Andreas Abel

README: clarify that `cache-hit` returns a string and not a boolean

1

Rationale: if `cache-hit` was a boolean, then `!` could be used to get the opposite. However, it is really a string, and this should be pointed out clearly in the...

`if: always()` with `cache/save` may lead to errors (fix README!)

5

https://github.com/actions/cache/blob/04f198bf0b2a39f7230a4304bf07747a0bddf146/save/README.md?plain=1#L83-L84 In my experience, if we had an exact cache hit, the attempt to save the cache (under the same key) will produce an error. So, the docs should be...

`!cache-hit` is `false` when `cache-hit` is `false`

6

This is the workflow I caught red-handed: https://github.com/andreasabel/hasktorch/actions/runs/6536754694/job/17749144021 1. Version: `actions/cache@v3` SHA:704facf57e6136b1bc63b828d79edcd491f0ee84 https://github.com/andreasabel/hasktorch/actions/runs/6536754694/job/17749144021 2. Cache restored from `restore-key` https://github.com/andreasabel/hasktorch/actions/runs/6536754694/job/17749144021#step:7:4 ``` Run actions/cache/restore@v3 with: path: ~/.cabal/store key: macOS-cabal-3.6.2.0-ghc-9.2.8-plan-813f23bfbcb4c800c8178d743c3df6e501ec38580a651c180dcd99b0abc9319d restore-keys: macOS-cabal-3.6.2.0-ghc-9.2.8- ......

https://github.com/haskell/containers/blob/3c13e0b03bde9aab4ce1ea7b23be1c713b89d32b/CONTRIBUTING.md?plain=1#L6-L7 Is the libraries mailing list still a thing? Shouldn't proposals be discussed on the issue tracker instead? The link to the core libraries process is outdated, and also `containers`...

Add `flattenSCC1 :: SCC a -> NonEmpty a`

4

This gives a more precise type to the existing `flattenSCC :: SCC a -> [a]`. Closes #985.

This repo has retained some old branches (as old as 12 years!) for PRs that are already merged. Should we delete them? 

Add `flattenSCC1 : SCC vertex -> Data.List.NonEmpty.NonEmpty vertex`

2

The `flattenSCC` function throws away the knowledge that a SCC is a non-empty list of vertices: https://github.com/haskell/containers/blob/a4e8d167c0c0f0001e48f499d33735a61c68d9d4/containers/src/Data/Graph.hs#L248-L251 In course of the new `x-partial` warning of GHC 9.8, this is a...

Almost a year ago I fixed `cabal test`: - #273 @deech: Can we get a release of `c2hs` with #273 and the other latest fixes? I would be good to...

Use `Foldable` instead of list?

1

I see that some functions, like [`concatWith`](https://hackage.haskell.org/package/prettyprinter-1.7.1/docs/Prettyprinter.html#v:concatWith) work for any `Foldable` instead of just for list. Is there a reason why the other list functions are not generalized to `Foldable`?...

`x-partial` warnings with GHC 9.8

1

``` src/Test/HUnit/Terminal.hs:41:41: warning: [GHC-63394] [-Wx-partial] In the use of ‘tail’ (imported from Prelude, but defined in GHC.List): "This is a partial function, it throws an error on empty lists. Replace...