andre-caldas

Library FFTW's fftw_plan_dft_r2c_1d is not thread safe.

1

The only thread-safe function in FFTW is `fftw_execute`. But the FFT filter calls `fftw_plan_dft_r2c_1d`. This makes MLT non-thread safe. One solution for this problem is making programs linking to MLT...

Does not rely on the pointervalue returned by getNameInDocument() to use as a DAG key.

4

I am splitting the PR https://github.com/FreeCAD/FreeCAD/pull/11053 into a sequence of simpler PRs. This is the second in this sequence. The first one is: https://github.com/FreeCAD/FreeCAD/pull/11139. Basically, the `DocumentObject::getNameInDocument()` method has three...

Compiler error.

1

I am getting that `dim` is a function, not a `short_t` variable. It should probably be `dim()`. Or `m_dim`... https://github.com/gismo/gismo/blob/4d2819ad2e131cbfc527b1553635188b73cc63b4/src/gsModeling/gsTemplate.h#L588 I might be saying something silly, I've just met G+Smo...

Relative or absolute CMAKE_INSTALL_XXXDIR variables.

4

I am not really familiar with `cmake`. I am very sorry if I am reporting something silly. :-) I have used `ogre-next-deps`. I have setup `CMAKE_CXX_FLAGS` and `CMAKE_INSTALL_PREFIX`. This is...

Fixes #16. CMake config variables `CMAKE_INSTALL_BINDIR` and `CMAKE_INSTALL_LIBDIR` must be relative to `CMAKE_INSTALL_PREFIX`.

In gsSurface::toMesh, we should call `gsMesh::reserve()` before populating the resulting `gsMesh & msh`, because `std::vector` does lots of copying/moving if we don't. https://github.com/gismo/gismo/blob/a9917ca7994633250ed2ae5686169febd46d64c3/src/gsCore/gsSurface.hpp#L25 Also, it seems `msh` is assumed to...

Allows multi-threading when rendering.

1

SWIG is capable of generating multi-threading code. We allow locking the GIL when python code is called from C++ through some virtual method. However, we do not automatically allow the...

When cmake is run with `-DGISMO_BUILD_LIB=OFF`, the file `gsCore/gsConfig.h` is not installed. Then, including (probably) any `.h` file gives a compilation error: > fatal error: gsCore/gsConfig.h: No such file or...