Andy
Andy
### What did you expect to happen? The CSS file being served minified. When served minified, the page will be loaded a little bit faster. ### What happened instead? The...
When resolving this issue we should have the following components: * [x] FacebookImage https://github.com/Yoast/yoast-components/issues/812 * [ ] FacebookTextContainer https://github.com/Yoast/javascript/issues/46 * [x] FacebookTitle https://github.com/Yoast/javascript/issues/40 * [x] FacebookDescription https://github.com/Yoast/javascript/issues/41 * [x] FacebookSiteName...
When creating the javascript packages we have copied the old textdomain (which is`yoast-components`). We should give proper new names to the translations.
We should set all version number to the same version for dependency that has been used the packages. This would make it easier to maintain the project and simplifies updating...
In the file `packages/yoast-components/composites/LinkSuggestions/LinkSuggestions.scss` we are using a relative path for importing a sass file from the style-guide. It would be better to convert it to `Styled Components`
We have some comments to classify the imports we make. Now we have external, internal and yoast. This is great however we use different styles: ``` /* Internal dependencies. */...
When we deprecate a method, function or hook we use the build in WordPress functions for it. One of the arguments these functions should receive the version number and that's...
### What did you expect to happen? That content would be displayed as I expected ### What happened instead? Content will be stripped ### How can we reproduce this behavior?...
Copy from https://github.com/Yoast/yoast-premium-components/issues/22 In this pull #21 we introduce the cornerstone content. As this is part of the linksuggestions, it logically belongs in the linksuggestions class. However, to improve loose...
Copy from: https://github.com/Yoast/yoast-premium-components/issues/12 See #11 (Add suggestions component) `Clipboard.js` uses `Document.execCommand()` to execute copy/cut operations. According to MDN, there's no great support on mobile browsers. See the "Mobile" tab on...