andig

Results 840 comments of andig

JonTheNiceGuy, I don't think you need all that. I've done a ``` class Auth_OpenID_PDO_DatabaseConnection extends Auth_OpenID_DatabaseConnection ``` and use that with an derived ``` Auth_OpenID_SQLiteStore ``` The only thing with...

> The errors package explicitly makes it hard to use for Singleton errors. Understood and thank you for your blog posts. > I suggest using the stdlib errors.new and wrapping...

+1 for this PR. I would prefer a different name though, maybe something like `SetSlaveId` or `SetTargetSlave`. With API available you could hide `SlaveId` as well which would be a...

I'd still greatly welcome this getting merged as it would get rid of ugly duck typing like this: if handler, ok := q.handler.(*modbus.RTUClientHandler); ok { handler.SlaveId = deviceid } else...

@wumingyu12 would you mind adding `Timeout` to the API in the same way (getter, setter)? I think its also used throughout the handlers and deserves the same api exposure?

@xft out of curiosity: what is your use case? Is this needed for RS485 to Ethernet adapters?

@wz2b I had ported the change (and some others) to the grid-x fork and wasn‘t aware of yours. Do you see any avantages over grid-x?

I‘ve ported this PR over to grid-x/modbus.

Great- I'd also like to add #33 to the wishlist :)