php-openid icon indicating copy to clipboard operation
php-openid copied to clipboard

Wishlist: Use PDO rather than Pear-DB, due to it's closer integration into the PHP core

Open JonTheNiceGuy opened this issue 13 years ago • 3 comments

This is something I plan to work on in the near future, however, it's more here in case anyone else wants to create the new SQL layer before I get around to it :)

JonTheNiceGuy avatar Oct 07 '11 21:10 JonTheNiceGuy

I'm definitely in favor of this.

wrikken avatar Jan 11 '12 18:01 wrikken

I have created a patch for this, but it's breaking on the signature validation.

https://github.com/JonTheNiceGuy/php-openid/commit/583d894d82c0781996458afe5bd7c3255b58fa57

Could someone please review what (if anything) I'm doing wrong? Thanks!

JonTheNiceGuy avatar Jan 23 '12 06:01 JonTheNiceGuy

JonTheNiceGuy,

I don't think you need all that. I've done a

class Auth_OpenID_PDO_DatabaseConnection extends Auth_OpenID_DatabaseConnection 

and use that with an derived

Auth_OpenID_SQLiteStore

The only thing with the Auth_OpenID_SQLiteStore is that you have to overwrite the isError() as it depends on PEAR. Working sofar but not extensively tested.

andig avatar Nov 22 '12 08:11 andig

This repo is being archived. Closing issue.

timcappalli avatar Jul 24 '23 18:07 timcappalli