Andreas Skomski
Andreas Skomski
That's why I like to have a fallback to English, it would make the missing translations visible for contributors using Photobooth in their mothers language. If there's no updated translations...
My thought of calling the en.js after the language.js does not work btw. Need to find a smarter solution
https://github.com/andreknieriem/photobooth/blob/master/resources/js/l10n.js#L11 How to make it check if the translation exist in en.js and use it if it exists? Something like ``` const item = $(this); const key = item.data('l10n'); const...
Same here, not an expert on that... and yeah... can't get it working to get the translation from en.js instead. Maybe @sualko has an idea how to get this solved.
https://github.com/philipptrenz/photo-booth/pull/95/commits/b37cebf1e8178adf366f67e0581d5f15d65924cc Not sure when I find time, but looks like a solution which we might be able to use too
Let's delay this to v2.1.1, v2.1.0 should be good to go now
I've played around with simple imagemagick filter too (on Pi3 and Pi4) but noticed the performance wasn't good, that's why I used the GD way. But I haven't tried PHP...
Guess we can close https://github.com/andreknieriem/photobooth/issues/111 and keep this here depending on how the rework looks like later?
https://github.com/andreknieriem/photobooth/pull/149 related to **1.**
https://phpimagick.com/Imagick Leaving this here in case imagick gets interesting in future. The webpage is available on GitHub too, effect examples can be seen there.