Anders Evenrud
Anders Evenrud
This theme uses an internal method: https://github.com/neovim/neovim/blob/5be2cdd913ce94bf3b88ce70042fbf7a92066459/runtime/lua/vim/highlight.lua#L6-L13 Suppose this ideally should be copied into this repo because it's marked as private, hence no guarantee to keep working in later releases...
To use the current (i.e. 0.6.1) `nvim_set_hl` signature you can just do this: ``` local ns = vim.api.nvim_create_namespace('nordic') vim.api.nvim_set_hl(ns, ...) ``` Not really sure if it's worth supporting the `0`...
I believe it will work exactly the same. The `0` argument is just a way to eliminate the need to create your own ns.
I see. I'm not familiar with this specific highlighting function, but in hindsight that makes sense... it's the same for virtual text which I've used extensively in another plugin I...
Since `vim.highlight.create` now emits a deprecation warning on main neovim branch, I added basic support for the new API. https://github.com/andersevenrud/nordic.nvim/commit/eb096c03853b8cc24457263c9ceed90256566118
Looks like the default styles for this plugin are linked to the default nvim ones, so it should be supported here out of the box :thinking: *Edit* I might have...
Maybe you could try https://github.com/andersevenrud/nordic.nvim/pull/80 ? I've added basic support for colors based on [their highlight definitions](https://github.com/stevearc/aerial.nvim/blob/ed25c56c3886d956cbe919f2710c0594c7021dca/lua/aerial/highlight.lua), but might not be what you're looking for. So some feedback would be...
> While this is much better (especially the AerialLine style for selected row), maybe it's also worth having different color applied to icons (groups like Aerial*Icon)? So that the text...
It looks to me like all of these examples use the same style. White text + Colored Icon. I'm a bit worried that having different colors will make things visually...
I could not get back to this the day I mentioned in the PR, but it's in now with some minor adjustments :sweat_smile: I went for the first option as...