Anders Christian Mathisen
Anders Christian Mathisen
Thank you for the excellent feedback, @hakonanes. Glad to see the test you wrote works:) Regarding the sorting of the parameters, I have inserted the symmetry argument in method `from_align_vectors()`...
I have added some examples in the docstrings of the methods. These are probably not the best examples, but probably work fine? I would however have liked to have a...
Yes, that is perfectly fine with me :)
> How would you like your name listed in the credits @anderscmathisen, "Anders Christian Mathisen"? I'll add your name with NTNU as the affiliation in the [Zenodo metadata file](https://github.com/pyxem/orix/blob/develop/.zenodo.json). Anders...
I think my last commits here are consistent with our discussions on this PR. The current implementation uses matrix for scipy conversion and also inverts the scipy rotation. I added...
> The solution I see is that when a lattice is not given, we set it to (1, 1, 1, 90, 90, 90) unless the symmetry given belongs to the...
Thanks for the swift response. I indeed initially tried to use `map_into_symmetry_reduced_zone()`, but when it did not provide the desired results, I choose the euler fundamental zone instead. I agree...
Hi, I have been testing with #442 and indeed that seems to solve all the issues with mean orientation :) As we discussed offline @hakonanes, we should rebase this PR...
Hmm yes I suppose I have accidentally used the right-to-left convention in combining the rotations. In the passive rotation left-to-right convention, I guess the transformation would be $$ g =...
Hmm, yes I suspected it might have something to do with a projection, however, I thought that `angle_with()`, which according to docs calculates the smallest symmetry reduced angle, should give...