Andrew Scott
Andrew Scott
Added PR #2439, thanks!
Just FYI that I created #2457 related to this issue. Possibly the last time you'll hear from me for this year's Hacktoberfest, so I just want to give a big...
Hey @omeryusufyagci, while I'm not super happy with how this turned out, it's hardly generic, it will hopefully help progress a little. [18ecf49](https://github.com/omeryusufyagci/fast-music-remover/pull/95/commits/18ecf49515251d8f330abcb3e36a370aec29e59f): pretty simple here, just replaced the C-style...
Greetings, I'd like to take a look at this if that's alright. It seems fairly straightforward, but are there any particular concerns you have?
Hi there @omeryusufyagci, a little refactoring never hurt anyone ;) I have some time set aside today to work on this, and I'm debating whether I want to make it...
I think I follow you, and yes definitely an improvement to the hardcoded commands! I'll need to change around some things but no big deal, will let you know if...
@omeryusufyagci Sorry I realized I didn't answer your question. I suppose I would prefer to tackle `FFmpegCommandBuilder` separately, but just to make sure I'm understanding correctly - as of now...
Hey @omeryusufyagci, wanted to check if the revisions for #60 (commit 467fe76ea57938ad2509c62bb05f4220eb6e4b85 on my branch) took care of this? If any refactoring is needed I'll have some time this week/next...
Greetings, I can take a look for Hacktoberfest if you'd like to assign to me
Hey @omeryusufyagci thanks for reviewing! At this point a discussion might be helpful. I do see what you mean about the "builder" not having getters, I think where I'm getting...