Josh Marshall

icon indicating an email [email protected]

icon location Branford, CT icon location I only actively maintain the TF-Cluster and madlib repositories at this time. I will, however, fix other code in my repositories upon request.

Results 88 comments of Josh Marshall

dijkstra_shortest_paths_no_init supports pruning on distances

@wygos Upstream devel has TravisCI tests which your is missing. Your tests are also failing. Please rebase.

update examples using graphviz

I'm particularly interested in this PR since graphviz needs some attention. Just address my review comment and I'll call in to get this merged.

Changed the output given in example

It looks like the previous output was generated by running the program. Could you look more into what might have caused this change?

Changed the output

Could you be more literal in what is incorrect? It looks like you're changing documentation and no code.

Changed the output

I have serious misgivings about correctness here. Those examples are old and when they were originally made they were *very* likely validated. It it possible internal behavior has changes or...

tiernan_all_cycles doesn't work out of the box with adjacency_list

I'll get to reading everything either today or tomorrow.

tiernan_all_cycles doesn't work out of the box with adjacency_list

Actually, reading this, I kind of want to reimplement the whole thing.

revising BGL code (isomorphism.hpp) that uses abort()

Quite possibly. I'll ask about it. Thank you for bringing this to attention.

revising BGL code (isomorphism.hpp) that uses abort()

Looks like the general advice is to avoid using aborts, with Peter Dimov pointing me towards https://github.com/boostorg/graph/blob/develop/include/boost/graph/isomorphism.hpp#L316 . This seems like an easy PR, so would you like the credit?...

Protect <> in examples

I'll queue this up for documentation fixes after I'm done with CI.