Matt Joiner comments

Results 837 comments of


                                            Matt Joiner

op-node: Improve shutdown behavior

I don't quite follow. My testing shows p2p is still used until the driver is shutdown. So if it's okay to stop sequencing, then the driver, then p2p that should...

Possible Bug: `AddPeer` stores only IP as key, but `GetPeers` expects full NodeAddr binary

Sorry, I haven't had time to look at this yet.

CPU usage rises very high

I've noticed it happen after lots of connects and disconnects. I can provide profiles if this helps and is the direction the existing profiles above are heading.

runtime/pprof: labels are not added to profiles

Will this be merged soon?

Allow rpiCameraSecondary with h264 codec

It's not clear how to even view the stream as mjpeg

`erigon snapshots reset` fails on mounted chaindata directory and may break symlink setups

Just to check, do we want the behaviour for snapshots too, or just the extra dirs like chaindata and ``` dbcfg.HeimdallDB, dbcfg.PolygonBridgeDB, ```

`erigon snapshots reset` fails on mounted chaindata directory and may break symlink setups

@lemenkov can you share an example symlink path you are using? I want to be certain regarding following symlinks into parent directories.